Add testing_commitBlockV1 RPC Method#787
Open
marcindsobczak wants to merge 1 commit into
Open
Conversation
Contributor
|
This will need, at a minimum, ACDE or ACDT buy in and someone willing to write at least one client implementation, preferably in Geth |
Author
|
It's already implemented in Nethermind: We are using it to effectively bloat a state. |
This was referenced May 18, 2026
Contributor
|
Hey @marcindsobczak - please see: #801 I opened a PRs against go-ethereum, nethermind, and hive to align spec and and implementations and generate the test fixtures. |
s1na
reviewed
Jun 17, 2026
| `null` if the block could not be built, validated, or committed; in that case the reason is returned via a JSON-RPC error response. | ||
| oneOf: | ||
| - $ref: '#/components/schemas/hash32' | ||
| - type: 'null' |
Contributor
There was a problem hiding this comment.
This looks off to me. The response should be just the hash. We don't need to specify null here for the error case because in JSON-RPC if we return an error then there is no response returned.
AnkushinDaniil
added a commit
to NethermindEth/state-benchmarks
that referenced
this pull request
Jun 18, 2026
- Author labels are now @GitHub-handles, linked to profiles (no real names). - Add two upstream Ethereum PRs that standardize the project's tooling: ethereum/execution-apis#787 (testing_commitBlockV1 RPC, open) and ethereum/execution-specs#2746 (Spamoor → EEST migration, draft).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #705
which was partially addressed by already specified
testing_buildBlockV1#747 & #710.tesitng_commitBlockV1is working similar totesting_buildBlockV1, but instead of returning a new payload, it is commiting it to the main chain and returning only hash of commited block (ornullin case of fail).This method will be useful for extensive bloating - eliminates overhead of:
engine_newPayloadHere, generated new payload will be directly validated and commited to the main chain and only block hash will be returned as a confirmation of success (or 'null' if fails)