Add testing_commitBlockV1 RPC Method#787
Open
marcindsobczak wants to merge 1 commit intoethereum:mainfrom
Open
Add testing_commitBlockV1 RPC Method#787marcindsobczak wants to merge 1 commit intoethereum:mainfrom
marcindsobczak wants to merge 1 commit intoethereum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #705
which was partially addressed by already specified
testing_buildBlockV1#747 & #710.tesitng_commitBlockV1is working similar totesting_buildBlockV1, but instead of returning a new payload, it is commiting it to the main chain and returning only hash of commited block (ornullin case of fail).This method will be useful for extensive bloating - eliminates overhead of:
engine_newPayloadHere, generated new payload will be directly validated and commited to the main chain and only block hash will be returned as a confirmation of success (or 'null' if fails)